Skip to content

some change #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bott0n wants to merge 2 commits into
base: master
Choose a base branch
from
Open

some change #1

bott0n wants to merge 2 commits into from

Conversation

@bott0n
Copy link
Collaborator

@bott0n bott0n commented Mar 21, 2018

Add i18n.js
Set default country-code
Tidy up some syntax

bott0n added 2 commits March 21, 2018 23:35
@bott0n
some change
f2ef600 
Add i18n.js
Set default country-code
Tidy up some syntax
@bott0n
delete jquery
cecb3e3 
delete jquery
@JasonHK JasonHK self-assigned this Mar 25, 2018
@JasonHK JasonHK added the enhancement New feature or request label Mar 25, 2018
@JasonHK
Copy link
Owner

JasonHK commented Mar 25, 2018

If you change the for="..." to data-i18n="...", I would merge your pull request.

@JasonHK JasonHK added the good first issue Good for newcomers label Mar 25, 2018
@bott0n
Copy link
Collaborator Author

bott0n commented Mar 26, 2018

do it yourself la

@JasonHK JasonHK added this to the v1.0 milestone Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JasonHK JasonHK

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Milestone

v1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bott0n @JasonHK